Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user deletion when we add more than one user #269

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Dec 18, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35657
  • Here is a brief description of what this PR does

When we try to add several technicians to a ticket with the escalation plugin enabled and the Remove technician(s) on escalation option active, only 1 is assigned.

Screenshots (if appropriate):

Screencast-from-18-12-2024-15_03_20

@Lainow Lainow requested review from stonebuzz and Rom1-B December 18, 2024 14:05
inc/ticket.class.php Show resolved Hide resolved
@stonebuzz
Copy link
Contributor

Can you do a git-bisect(between 2.9.8 and 2.9.10 to know which commit would have broken the option

(from memory that part had been reworked #219)

Mayve the related commit is involved

@Lainow Lainow force-pushed the fix-user-deletion branch 7 times, most recently from e4c9744 to 08e2fe7 Compare December 19, 2024 11:10
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adapt CHANGELOG.md

@Lainow Lainow force-pushed the fix-user-deletion branch 6 times, most recently from bd4c694 to cf55101 Compare December 19, 2024 14:26
@Lainow Lainow force-pushed the fix-user-deletion branch 3 times, most recently from d57c29d to 1a00d19 Compare December 30, 2024 09:00
@Lainow Lainow force-pushed the fix-user-deletion branch 15 times, most recently from eee05ab to d2c5dab Compare December 30, 2024 12:53
@Lainow Lainow assigned Lainow and unassigned RomainLvr and Lainow Dec 30, 2024
@Lainow Lainow force-pushed the fix-user-deletion branch 9 times, most recently from 11879c5 to aa7d971 Compare December 30, 2024 16:28
@Lainow Lainow force-pushed the fix-user-deletion branch from aa7d971 to 7f6c85a Compare January 2, 2025 10:51
@Lainow Lainow requested a review from Rom1-B January 2, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants