-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user deletion when we add more than one user #269
Open
Lainow
wants to merge
4
commits into
pluginsGLPI:main
Choose a base branch
from
Lainow:fix-user-deletion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+131
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
requested changes
Dec 18, 2024
Can you do a (from memory that part had been reworked #219) Mayve the related commit is involved |
Lainow
force-pushed
the
fix-user-deletion
branch
7 times, most recently
from
December 19, 2024 11:10
e4c9744
to
08e2fe7
Compare
stonebuzz
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adapt CHANGELOG.md
Lainow
force-pushed
the
fix-user-deletion
branch
6 times, most recently
from
December 19, 2024 14:26
bd4c694
to
cf55101
Compare
Lainow
force-pushed
the
fix-user-deletion
branch
from
December 19, 2024 14:35
cf55101
to
47eb3db
Compare
Rom1-B
requested changes
Dec 23, 2024
Lainow
force-pushed
the
fix-user-deletion
branch
3 times, most recently
from
December 30, 2024 09:00
d57c29d
to
1a00d19
Compare
Lainow
force-pushed
the
fix-user-deletion
branch
15 times, most recently
from
December 30, 2024 12:53
eee05ab
to
d2c5dab
Compare
Lainow
force-pushed
the
fix-user-deletion
branch
9 times, most recently
from
December 30, 2024 16:28
11879c5
to
aa7d971
Compare
Lainow
force-pushed
the
fix-user-deletion
branch
from
January 2, 2025 10:51
aa7d971
to
7f6c85a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When we try to add several technicians to a ticket with the escalation plugin enabled and the Remove technician(s) on escalation option active, only 1 is assigned.
Screenshots (if appropriate):